fix: date selection in filters #140
Conversation
src/components/Filter.js
Outdated
| @@ -285,7 +285,7 @@ function Filter(props) { | |||
| value={dateStart} | |||
| onChange={handleDateStartChange} | |||
| format={getDateFormatLocale(true)} | |||
| maxDate={dateEnd} | |||
| maxDate={dateEnd || Date('2100-01-01')} | |||
There was a problem hiding this comment.
Perhaps we could add these default values to the state on line 58-59 so we can keep the initial state and it's defaults in one place?
There was a problem hiding this comment.
If I've understood your suggestion correctly, that doesn't have quite the desired result.
We want to keep the actual dateStart and dateEnd unset so that no value is selected in the input.
It's only the minDate and maxDate props that we need to set.
There was a problem hiding this comment.
Ah, I misunderstood! Ok, that solution works. What do you think about adding comments to explain why the dates are there? or to create variables maxDateDefault and minDateDefault? I'm concerned with someone changing or deleting the defaults in a refactor.
This would be a good thing to have a test for...
There was a problem hiding this comment.
That's a good shout, thanks. I'll make it a bit more explicit and add a test or two.
src/components/FilterTop.js
Outdated
| @@ -230,7 +230,7 @@ function Filter(props) { | |||
| format={getDateFormatLocale(true)} | |||
| value={dateStart} | |||
| onChange={handleDateStartChange} | |||
| maxDate={dateEnd} | |||
| maxDate={dateEnd || Date('2100-01-01')} | |||
There was a problem hiding this comment.
Same as with Filter.js we can set defaults on lines 72-73 so they are set from the start.
|
@nikolamilijevic1 what's your opinion in terms of the usage of the cypress unit test, is it okay? Or there still are some barriers using it. |
|
The "fix" doesn't work quite as it should; needs a little more work 🤔 |
|
Modified behaviour to not allow date selection after today (since all data in the platform is historic), but to allow arbitrary start and end date selection in the past if the other value has not been set. |
Resolves #94
A
nulldate passed intoKeyboardDatePickerasminDateormaxDatecauses the back and forward buttons respectively to be permanently disabled.1900-01-01and2100-01-01are the default values for these properties (see https://material-ui-pickers.dev/api/DatePicker).